Skip to content

Plugin-review follow-ups: unused import, Tailwind imports, fewer !important - #470

Merged
Leo310 merged 1 commit into
mainfrom
chore/review-css-followups
Sep 5, 2026
Merged

Plugin-review follow-ups: unused import, Tailwind imports, fewer !important#470
Leo310 merged 1 commit into
mainfrom
chore/review-css-followups

Conversation

@Leo310

@Leo310 Leo310 commented Sep 5, 2026

Copy link
Copy Markdown
Member

Small follow-ups from the latest plugin review of 2.0.3.

  • 'Platform' is defined but never used — dropped from AgentManager (left over from the stdio removal in Drop stdio MCP; keep process spawning and eval out of the bundle #467).
  • Unexpected unknown at-rule "@tailwind" ×3 — the Tailwind layers are now @import "tailwindcss/base.css" etc. Vite expands them exactly as before; the built styles.css is byte-for-byte the same rules.
  • Avoid !important — five declarations that only had to beat core's specificity are rewritten with a more specific selector and verified live in a slot vault:
    • graph view padding (.workspace-leaf-content .view-content.smart-graph-container),
    • search filter chips (.s2b-search-modal button.s2b-inline-chip, background + shadow, incl. hover),
    • search modal glow border — this one targets .prompt now; SuggestModal's element never carries .modal, so the old selector I introduced in Resolve Obsidian plugin-review findings #465 could not have matched. !important had masked that.

The other ~50 !important declarations in src/styles.css stay: they override theme rules that are themselves !important (Cupertino/Baseline input padding, phone-sheet header buttons), or raise mobile touch-target floors above sizes our own component styles pin. Removing those needs on-device verification and is out of scope here.

Not addressed: getSettingDefinitions() (declarative settings API), display: contents / text-indent partial-support notes.

Test plan

  • bun run check, format, lint, test, build
  • Live: graph container padding 0; chip background/shadow correct vs a plain button; glow border transparent when the class is on

…ortant

- AgentManager no longer imports Platform (unused since stdio MCP went).
- The Tailwind layers come in through @import of tailwindcss/*.css instead
  of the @tailwind at-rules, so src/styles.css is plain CSS to any linter;
  the built stylesheet is unchanged.
- Three overrides that only had to beat core's specificity drop their
  !important: the graph view's padding (names .view-content's ancestor),
  the search chips (names the button element and the modal), and the
  search modal's glow border (names .prompt, which is what SuggestModal's
  element actually carries — the previous .modal-based selector could
  never have matched). Verified live: padding 0, chips tinted without a
  shadow, border transparent. The remaining !important declarations beat
  theme !important rules or mobile touch-target sizing and stay.
@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR performs focused plugin-review cleanup without changing application behavior:

  • Removes the unused Platform import from AgentManager.
  • Replaces Tailwind-specific layer directives with resolvable Tailwind CSS imports.
  • Uses DOM-aware selector specificity instead of five !important declarations for search chips, graph padding, and the search-modal glow border.

Confidence Score: 5/5

The PR appears safe to merge; the updated selectors match the current component DOM and no actionable regression was identified.

The import cleanup is behavior-neutral, the Tailwind layer paths are supported by the pinned toolchain, and each replacement selector targets the classes and ancestry assigned by the corresponding view or modal implementation.

Important Files Changed

Filename Overview
src/agent/AgentManager.ts Removes an unused Obsidian type import with no runtime impact.
src/styles.css Reworks Tailwind layer imports and narrows several specificity overrides to selectors matching the existing DOM structure.

Reviews (1): Last reviewed commit: "Plugin-review follow-ups: unused import,..." | Re-trigger Greptile

@Leo310
Leo310 merged commit 7a66708 into main Sep 5, 2026
3 checks passed
@Leo310
Leo310 deleted the chore/review-css-followups branch September 5, 2026 15:18
Leo310 added a commit that referenced this pull request Sep 5, 2026
Dependency updates with every advisory cleared (#469) and the last
plugin-review follow-ups (#470). No user-facing change intended.

minAppVersion unchanged at 1.11.4. Nothing touched PROVIDER_TEMPLATES,
src/skills/defaults/, BUILT_IN_TOOL_IDS or CURATED_PLUGIN_INTEGRATIONS,
so the site's enumerable facts need no refresh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant