Plugin-review follow-ups: unused import, Tailwind imports, fewer !important - #470
Merged
Conversation
…ortant - AgentManager no longer imports Platform (unused since stdio MCP went). - The Tailwind layers come in through @import of tailwindcss/*.css instead of the @tailwind at-rules, so src/styles.css is plain CSS to any linter; the built stylesheet is unchanged. - Three overrides that only had to beat core's specificity drop their !important: the graph view's padding (names .view-content's ancestor), the search chips (names the button element and the modal), and the search modal's glow border (names .prompt, which is what SuggestModal's element actually carries — the previous .modal-based selector could never have matched). Verified live: padding 0, chips tinted without a shadow, border transparent. The remaining !important declarations beat theme !important rules or mobile touch-target sizing and stay.
Contributor
Greptile SummaryThis PR performs focused plugin-review cleanup without changing application behavior:
Confidence Score: 5/5The PR appears safe to merge; the updated selectors match the current component DOM and no actionable regression was identified. The import cleanup is behavior-neutral, the Tailwind layer paths are supported by the pinned toolchain, and each replacement selector targets the classes and ancestry assigned by the corresponding view or modal implementation. Important Files Changed
Reviews (1): Last reviewed commit: "Plugin-review follow-ups: unused import,..." | Re-trigger Greptile |
Leo310
added a commit
that referenced
this pull request
Sep 5, 2026
Dependency updates with every advisory cleared (#469) and the last plugin-review follow-ups (#470). No user-facing change intended. minAppVersion unchanged at 1.11.4. Nothing touched PROVIDER_TEMPLATES, src/skills/defaults/, BUILT_IN_TOOL_IDS or CURATED_PLUGIN_INTEGRATIONS, so the site's enumerable facts need no refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-ups from the latest plugin review of 2.0.3.
'Platform' is defined but never used— dropped fromAgentManager(left over from the stdio removal in Drop stdio MCP; keep process spawning and eval out of the bundle #467).Unexpected unknown at-rule "@tailwind"×3 — the Tailwind layers are now@import "tailwindcss/base.css"etc. Vite expands them exactly as before; the builtstyles.cssis byte-for-byte the same rules.Avoid !important— five declarations that only had to beat core's specificity are rewritten with a more specific selector and verified live in a slot vault:.workspace-leaf-content .view-content.smart-graph-container),.s2b-search-modal button.s2b-inline-chip, background + shadow, incl. hover),.promptnow; SuggestModal's element never carries.modal, so the old selector I introduced in Resolve Obsidian plugin-review findings #465 could not have matched.!importanthad masked that.The other ~50
!importantdeclarations insrc/styles.cssstay: they override theme rules that are themselves!important(Cupertino/Baseline input padding, phone-sheet header buttons), or raise mobile touch-target floors above sizes our own component styles pin. Removing those needs on-device verification and is out of scope here.Not addressed:
getSettingDefinitions()(declarative settings API),display: contents/text-indentpartial-support notes.Test plan
bun run check,format,lint,test,build