Prepare samebase/app for public release - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
samebase/appis close to public beta. Its README duplicated the hosted setup guide, and the repository had no public license, security policy, third-party notice, or CI. A review also found a critical Auth.js advisory in the starter dependency graph.What changed
js-yamlandpostcssreleases.Convex file licensing
The installed Convex AI files and skills are byte-identical to the Apache-2.0 licensed
get-convex/templatessnapshot linked inTHIRD_PARTY_NOTICES.md. The Heroicons MIT notice is included.Security result
@auth/coreadvisory GHSA-7rqj-j65f-68wh is fixed.pnpm audit --prodreports no known production vulnerabilities.Validation
vp run checkpnpm audit --prodpnpm audit --dev --audit-level=criticalpnpm audit signaturesCLOUDFLARE_WORKER_NAME=samebase-app-readiness vp run deploy:dry-runCLOUDFLARE_WORKER_NAME=samebase-app-readiness vp run deploy:preview:dry-runBoth Wrangler dry-runs completed without publishing.
Follow-up outside this PR
Resolve #25, close #22 after this replacement lands, clean old remote branches, enable public security settings, and change visibility only after those steps.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.