Let screen return casefile JSON without writing a case directory - #10
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
| Filename | Overview |
|---|---|
| src/coldscreen/pipeline.py | Adds a keyword-only no-write mode that bypasses overwrite checks and case persistence while retaining the complete in-memory screening pipeline. |
| src/coldscreen/cli.py | Exposes --no-write, emits casefile JSON once, and reports persistence and failure status through stderr appropriately. |
| src/coldscreen/mcp_server.py | Adds the no_write tool argument and returns successful no-write results with a null case_dir. |
| tests/test_cli.py | Covers JSON output, absent and existing case directories, overwrite interaction, help text, and continued HTTP caching. |
| tests/test_mcp_server.py | Covers the expanded MCP schema and successful no-write payload without case-directory creation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CLI or MCP screen request] --> B[Run screening pipeline]
B --> C[Build casefile and memo in memory]
C --> D{no_write?}
D -- Yes --> E[Skip case-directory persistence]
E --> F[Return casefile, memo, verdict, and null case_dir]
D -- No --> G[Write memo, casefile, and evidence]
G --> H[Return persisted case directory]
B --> I[HTTP cache reads and successful writes]
I --> C
Reviews (1): Last reviewed commit: "Let screen return casefile JSON without ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coldscreen screen ... --no-write(and MCPno_write) skips the case directory for that run only: no mkdir, no memo, no casefile, no evidence.--no-writeprints the casefile JSON to stdout the same way--jsondoes. The HTTP cache still stores 200s.--overwrite --no-writedoes not delete an existing directory.rerundid not grow the flag.Test plan
uv run pytest(744 passed)uv run ruff check ./ruff format --check .uv run mypyuv run python scripts/check_language.py