Skip to content

fix(deps): bump @sasjs/adapter, @sasjs/core, @sasjs/utils and fix vul… - #1456

Merged
allanbowe merged 1 commit into
mainfrom
npm-dependencies
Jul 21, 2026
Merged

fix(deps): bump @sasjs/adapter, @sasjs/core, @sasjs/utils and fix vul…#1456
allanbowe merged 1 commit into
mainfrom
npm-dependencies

Conversation

@YuryShkoda

@YuryShkoda YuryShkoda commented Jul 21, 2026

Copy link
Copy Markdown
Member

Issue

npm audit reported 6 vulnerabilities (4 high, 2 low) in this repo's dependency tree, and the @sasjs/* packages were behind their latest published versions:

  • @sasjs/adapter 4.17.1 (latest: 4.17.2)
  • @sasjs/core 4.67.3 (latest: 4.68.1)
  • @sasjs/utils 3.5.8 (latest: 3.5.9)

High-severity findings included adm-zip (crafted ZIP file triggers 4GB memory allocation, GHSA-xcpc-8h2w-3j85), @babel/plugin-transform-modules-systemjs, brace-expansion, and js-yaml. Low-severity findings included @babel/core (arbitrary file read via sourceMappingURL comment, GHSA-4x5r-pxfx-6jf8) and @tootallnate/once.

Intent

Update the @sasjs family of dependencies to their latest patch releases and eliminate all currently known vulnerabilities in the dependency tree, without introducing any behavioral regressions to compile/build/create/deploy flows that rely on these packages (macro resolution via @sasjs/core, adapter calls via @sasjs/adapter, zip handling via adm-zip for sasjs create/sasjs build).

Implementation

  • Bumped @sasjs/adapter 4.17.1 → 4.17.2, @sasjs/core 4.67.3 → 4.68.1, @sasjs/utils 3.5.8 → 3.5.9 (@sasjs/lint was already at latest, 2.4.3).
  • Bumped adm-zip 0.5.10 → 0.6.0 to resolve the high-severity zip-bomb advisory. This is a direct dependency used in src/utils/utils.ts (createApp, loadDocsSubmodule) and src/utils/compressAndSave.ts (sasjs build) — verified the new AdmZip() / extractAllTo / addFile / writeZipPromise API surface used here is unchanged.
  • Bumped @babel/core 7.22.0 → 7.29.7 (dev-only, used by babel-jest/ts-jest transform for tests) to resolve the low-severity file-read advisory. Same major version, no config changes needed.
  • Ran npm audit fix (non-force) to pull in patched transitive versions of @babel/plugin-transform-modules-systemjs, @tootallnate/once, brace-expansion, and js-yaml.
  • Result: npm audit now reports 0 vulnerabilities (down from 6).

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • Unit tests coverage has been increased and a new threshold is set.
  • All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and a new threshold is set.
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

…nerabilities

Bumps @sasjs/adapter (4.17.1 -> 4.17.2), @sasjs/core (4.67.3 -> 4.68.1),
and @sasjs/utils (3.5.8 -> 3.5.9). Also bumps adm-zip (0.5.10 -> 0.6.0)
and @babel/core (7.22.0 -> 7.29.7, dev-only) to close out two npm audit
findings (GHSA-xcpc-8h2w-3j85, GHSA-4x5r-pxfx-6jf8), with the remaining
transitive advisories cleared via `npm audit fix`. `npm audit` now
reports 0 vulnerabilities.
@github-actions

Copy link
Copy Markdown

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 74% 3341/4515
🟡 Branches 60.67% 1325/2184
🟡 Functions 74.02% 678/916
🟢 Lines 82.72% 8480/10252

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟡 src/utils/config.ts 58.29% 55.52% 63.79% (+1.72% 🔼) 64.57%
🟢 src/utils/test.ts 84.66% (-1.14% 🔻) 68.12% 77.14% 92.14%
🟢 src/commands/compile/compileSingleFile.ts 95.83% (-2.08% 🔻) 84% (-4% 🔻) 100% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from f385b3e

@allanbowe
allanbowe merged commit f3e48e8 into main Jul 21, 2026
2 checks passed
@allanbowe
allanbowe deleted the npm-dependencies branch July 21, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants