feat: add demo.sql golden test file with 5 impactful SQLFluff issues - #3
Open
sauravsrijan wants to merge 1 commit into
Open
feat: add demo.sql golden test file with 5 impactful SQLFluff issues#3sauravsrijan wants to merge 1 commit into
sauravsrijan wants to merge 1 commit into
Conversation
This commit adds a new golden test file (demo.sql) that demonstrates 5 of the most impactful SQLFluff issues for SQL code quality analysis: 1. AL03 (aliasing.expression) - Column expression without explicit alias 2. AM06 (ambiguous.column_references) - Inconsistent column references in GROUP BY 3. AM09 (ambiguous.order_by_limit) - Use of LIMIT without ORDER BY 4. CV05 (convention.is_null) - NULL comparison without IS NULL 5. AL01 (aliasing.table) - Implicit table aliasing Also includes comprehensive test suite (test_demo.py) with 9 tests that validate: - File structure and size constraints (<100 lines) - Presence of each impactful issue - Meaningful violation descriptions - At least 5 different issue types detected All tests pass successfully. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new golden test file (
demo.sql) that demonstrates 5 of the most impactful SQLFluff issues for SQL code quality analysis. The file is designed as a production-realistic example showing common SQL anti-patterns.Key Issues Demonstrated
Implementation Details
Test Results
✅ All 9 tests passing:
Test Plan
🤖 Generated with Claude Code