Skip to content

fix(auth): harden session cookie (HttpOnly/Secure/SameSite) #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ttonyxx wants to merge 1 commit into
base: security/01-verify-google-id-token
Choose a base branch
from
Open

fix(auth): harden session cookie (HttpOnly/Secure/SameSite) #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,21 @@ func main() {

// Session
store := cookie.NewStore([]byte(os.Getenv("SESSION_SECRET")))
// Harden the session cookie. Without these flags the gorilla cookie store
// defaults leave the session cookie readable by JavaScript (no HttpOnly),
// sendable over plain HTTP (no Secure), and with no explicit SameSite,
// making session theft via XSS and CSRF much easier.
// - HttpOnly: keep the cookie out of reach of page JavaScript.
// - Secure: only send over HTTPS in production (left off in dev so
// http://localhost still works).
// - SameSite=Lax: mitigate CSRF while still allowing top-level navigations.
store.Options(sessions.Options{
Path: "/",
MaxAge: 60 * 60 * 24 * 30, // 30 days
HttpOnly: true,
Secure: utils.IsRelease(),
SameSite: http.SameSiteLaxMode,
})
router.Use(sessions.Sessions("session", store))

// Init routes
Expand Down