Keep the test harness off stderr, and off the parent's colour settings - #2
Merged
Merged
Conversation
prepublishOnly refused to publish 0.1.0: two tests failed on a machine with FORCE_COLOR set, and passed everywhere else. The helper set NO_COLOR on the child while FORCE_COLOR was inherited from the parent. Node warns on stderr when both are set, and the failure branch merged stderr into stdout before JSON.parse, so a harmless warning became "Unexpected non-whitespace character after JSON". The CLI was never at fault: its --json output is clean on stdout. - The child inherits neither colour variable; only NO_COLOR is set - stdout and stderr are returned separately, so what is parsed is what the command printed. No assertion needed stderr - New test: check --json stays parseable with both colour variables set, which is the environment shape that produced the warning Verified with FORCE_COLOR set, with NO_COLOR set, and with neither: 32 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepublishOnly refused to publish 0.1.0: two tests failed on a machine with FORCE_COLOR set, and passed everywhere else.
The helper set NO_COLOR on the child while FORCE_COLOR was inherited from the parent. Node warns on stderr when both are set, and the failure branch merged stderr into stdout before JSON.parse, so a harmless warning became "Unexpected non-whitespace character after JSON". The CLI was never at fault: its --json output is clean on stdout.
Verified with FORCE_COLOR set, with NO_COLOR set, and with neither: 32 pass.
Summary
Type
Devia compliance
.devia/layout, CLI contract):CHANGELOG.mdupdated:npm run build:index):Checks
npm run validatepassesnpm testpassesnode bin/devia.mjs check --root .passesdevia initstill produces a valid project (devia validateclean in a scratch repo)Not verified