Drop empty annotation rows from plot_da_beeswarm - #1078
Open
Zethson wants to merge 1 commit into
Open
Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1078 +/- ##
==========================================
- Coverage 79.46% 79.45% -0.02%
==========================================
Files 53 53
Lines 7545 7546 +1
==========================================
Hits 5996 5996
- Misses 1549 1550 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1076.
The row order was derived from
nhood_adata.obsbefore the"nan"annotations were filtered out and with the pandas default ofobserved=False, so annotation categories without any neighbourhood were drawn as empty rows.The order now comes from the plotted frame with
observed=True, which also makes the plot independent of the pandas version -- the default flipped toTruein pandas 3.0, so this only shows up for users on pandas 2.