Skip to content

Fix delay calibration tests on Python 3.14 - #698

Merged
sdatkinson merged 1 commit into
mainfrom
fix-python-314-partial-test-binding
Aug 23, 2026
Merged

sdatkinson merged 1 commit into
mainfrom
fix-python-314-partial-test-binding

Conversation

@sdatkinson

Copy link
Copy Markdown
Owner

Summary

  • preserve the delay-calibration tests' existing calling convention on Python 3.14
  • wrap functools.partial class attributes with staticmethod so instances do not bind an extra self argument
  • keep the same behavior on Python 3.10 through 3.13

Tests

  • python -m pytest -q tests/test_nam/test_train/test_core.py (27 passed, 15 skipped)
  • python -m pytest -q tests/test_nam/test_train/test_core.py -k 'TestCalibrateDelay' (20 passed)
  • python -m flake8 tests/test_nam/test_train/test_core.py --count --select=E9,F63,F7,F82 --show-source --statistics

The Python 3.14 CI matrix job provides the final cross-version verification because Python 3.14 is not installed in the local development environment.

@sdatkinson
sdatkinson merged commit 333566f into main Aug 23, 2026
6 checks passed
@sdatkinson
sdatkinson deleted the fix-python-314-partial-test-binding branch August 23, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant