Fix Sequential model serialization format - #699
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sequentialas a true container whoseconfig.modelsentries are complete child NAM objectsweightsempty so each child owns its architecture, configuration, weights, and sample rate"Sequential".namfile versionThis aligns trainer exports with the Sequential support merged in NeuralAmpModelerCore#323 and supersedes the experimental serialization introduced in #596.
The branch is based on the current
main, including the Linear tap-order fix from #697. Its chronological-tap test now verifies the weights inside each exported child rather than the removed flattened wrapper weights.Tests
python -m pytest -q tests/test_nam/test_models/test_sequential.py tests/test_nam/test_models/test_from_nam.py tests/test_nam/test_models/test_factory.py— 48 passed, 1 skippedpython -m pytest -q --ignore=tests/test_graceful_shutdown.py --ignore=tests/test_bin— 382 passed, 21 skippedpython -m black --check nam/models/_from_nam.py nam/models/sequential.py tests/test_nam/test_models/test_sequential.pypython -m sphinx -W -b html docs/source build/docs-htmlCompatibility note
Earlier experimental Sequential files stored bare child configs plus flattened top-level weights. Those files cannot be reconstructed reliably because they omit child architectures and weight boundaries, so this PR intentionally rejects them while retaining file version
0.7.0.