network_buildhosts: fail when hosts_path does not exist - #1007
Open
insatomcat wants to merge 1 commit into
Open
Conversation
A hosts_path pointing to a missing file was silently skipped: the stat task returned exists=false and the guarded block was skipped without a warning, making a typo indistinguishable from "no custom hosts file". The "when: hosts_path is defined" guard already covers the case where the operator does not want a custom file, so a missing path can only mean a mistake. Assert on it instead, and drop the now useless stat.exists guard on the tasks below. Signed-off-by: Florent Carli <florent.carli@rte-france.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
hosts_pathpointing to a missing file was silently skipped: the stat task returnedexists=falseand the guarded block was skipped without a warning, so a typo in the path looked exactly like a nominal run without a custom hosts file.The
when: hosts_path is definedguard already covers the "no custom file wanted" case, so a missing path can only be a mistake. Assert on it, and drop the now uselessstat.existsguard below.