optimize excel update import: query only needed columns instead of select * - #910
Open
AlexCXC wants to merge 1 commit into
Open
optimize excel update import: query only needed columns instead of select *#910AlexCXC wants to merge 1 commit into
AlexCXC wants to merge 1 commit into
Conversation
seafile-dev
requested changes
Sep 11, 2026
|
|
||
|
|
||
| def get_rows_from_dtable_db(dtable_db_api, table_name, limit=50000): | ||
| def get_rows_from_dtable_db(dtable_db_api, table_name, limit=50000, columns=None): |
There was a problem hiding this comment.
[Critical] 未将查询总量限制为 1 万
Why this matters:
这里仍保留 limit=50000，循环会按每页 10000 行继续请求至多五页。需求要求正常路径使用 LIMIT 1 万；在大表或复杂公式表中，累计读取 5 万行即使只查询必要列，预检和提交更新仍可能触发 execution cost exceeded，优化目标无法保证达成。
Suggested fix: 将此更新导入路径的总上限改为 10000（或显式传入该值），使正常路径只执行一次 1 万行查询；1 千行降级策略可按任务说明后续实现。
There was a problem hiding this comment.
复核更正：任务详情仅要求将查询从 SELECT * 收敛为必要列，并未要求把既有的最多 5 万行扫描上限改为 1 万行。当前实现已将匹配键、可更新导入列和 _id 传入查询；本线程中的“总量限制为 1 万”不应作为本次 PR 的阻塞项。
seafile-dev
approved these changes
Sep 11, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
复核确认：本次改动符合任务目标。预检与实际提交更新均只查询匹配键、可更新导入列和 _id，避免无关公式、链接等列参与 SQL 计算。此前关于将总量限制为 1 万行的意见不属于当前任务范围，已在先前审查说明中更正。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.