feat: add exact match indicator support to search input - #480
Open
SailingBoat762 wants to merge 1 commit into
Open
feat: add exact match indicator support to search input#480SailingBoat762 wants to merge 1 commit into
SailingBoat762 wants to merge 1 commit into
Conversation
Add renderExactMatch method to support custom ExactMatchIndicator component, allowing both element and function component types to be passed via components prop.
seafile-dev
approved these changes
Sep 11, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Approve
通用组件仅增加 ExactMatchIndicator 插槽，元素与函数组件均可渲染；未发现新的契约或兼容性问题。
seafile-dev
reviewed
Sep 12, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Comment
Warnings:
- 新增的 ExactMatchIndicator 插槽未覆盖元素和函数组件两种公开契约；见行内评论。
Suggested fix: 在现有搜索输入组件测试中覆盖两种渲染方式。
| ); | ||
| }; | ||
|
|
||
| renderExactMatch = () => { |
There was a problem hiding this comment.
[Warning] 新插槽缺少契约测试
Why this matters:
ExactMatchIndicator 是供多个业务入口使用的共享组件契约，代码明确支持 React 元素和函数组件两种输入，但本 PR 没有测试。任一分支在后续重构中失效都会导致精确匹配入口在所有调用方消失。
Suggested fix: 在 DTableSearchInput 的组件测试中分别传入元素和函数组件，并断言两者均渲染；同时保留未传入时不渲染的覆盖。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add renderExactMatch method to support custom ExactMatchIndicator component, allowing both element and function component types to be passed via components prop.