Conversation
Fires when a transparent refresh itself throws (refresh token revoked, expired, or rescoped) - character is unchanged, the triggering call still fails, but a registered sink now gets a chance to react (e.g. flag the character so other jobs stop querying it) before that exception propagates. Fixes the test build: FakeSink predated this interface member and didn't implement it. Adds a dedicated failure-path test and documents the hook in the README's DbTokenSink example and the CHANGELOG. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the release just cut (
2026.912.1). PR #84 addedIEsiTokenRefreshSink.OnRefreshFailedAsyncearlier tonight but was never actually merged intodev— it sat open, and its content shipped in neitherdevnor2026.912.1. Found while investigating why that PR's SonarCloud check was showing failed (the scan itself was erroring out, unrelated to this).Cherry-picked PR #84's commit directly onto current
dev(a plain merge would've conflicted across most of the Logic files, sincedevhad moved substantially further through this same session's CA1305/CA1707/CA1062/net10.0 work) and verified:net8.0andnet10.0(56 + the new failure-path test)PR #84 is closed as superseded.
🤖 Generated with Claude Code