refactor: improve taggedlen maintainability and logic - #578
Merged
Conversation
fereidani
force-pushed
the
v2_taggedlen_refactor
branch
from
September 4, 2026 19:46
7ff015d to
d96d8d6
Compare
fereidani
force-pushed
the
v2_taggedlen_refactor
branch
from
September 4, 2026 19:53
d96d8d6 to
04debc8
Compare
Signed-off-by: Khashayar Fereidani <info@fereidani.com>
Contributor
Author
|
This also fixes clippy CI failure. |
alejandro-vaz
approved these changes
Sep 5, 2026
alejandro-vaz
left a comment
alejandro-vaz
left a comment
Collaborator
There was a problem hiding this comment.
yeah this makes much more sense than what we had and it's easier to maintain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relation to #451,
This PR refactors taggedlen for better maintainability and slight sub percent performance improvement.
Highlights
len.parts()we can stop reading on_heap/spilled flag multiple times.MAX_LEN,SHIFTandTAGsimplifies maintaining the taggedlen.rs.