Add email into comment entities to be displayed alongside comments - #14
Open
sharmkn wants to merge 8 commits into
Open
Add email into comment entities to be displayed alongside comments#14sharmkn wants to merge 8 commits into
sharmkn wants to merge 8 commits into
Conversation
Marine5174-zz
approved these changes
Dec 28, 2020
| String image = (String) entity.getProperty("image"); | ||
| String comment = username + " (" + email + ") said:" | ||
| + "\n" + "\"" + text + "\"\n"; | ||
| + "\n" + "\"" + text + "\"\n" + "<br/> <img src=\"" + image + "\" /> <br/>"; |
Collaborator
There was a problem hiding this comment.
Usually it's not recommended to append many strings. It is not much readable.
Consider using String.format("%s (%s) said: \n"%s"
<img src="%s"/>
", username, email, text, image);
(It's not quite clear either, but should be slightly better).
Marine5174-zz
approved these changes
Dec 29, 2020
Marine5174-zz
approved these changes
Dec 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.