Skip to content

fix: enter coarse edit mode when clock is at preset value - #1

Open
sheldonsmith-ai wants to merge 1 commit into
mainfrom
feature/edit-mode-preset-adjust
Open

fix: enter coarse edit mode when clock is at preset value#1
sheldonsmith-ai wants to merge 1 commit into
mainfrom
feature/edit-mode-preset-adjust

Conversation

@sheldonsmith-ai

Copy link
Copy Markdown
Owner

Summary

  • Changes the edit mode entry condition from game_clock_ever_started() to current seconds != default seconds
  • When the game clock is at its preset value, edit mode now uses 60-second steps and saves the result as the new default on exit
  • The new default is persisted to storage immediately on exit

Test Plan

  • Launch app (clock at default, e.g. 25:00) → long-press SELECT → up/down should move in 1-minute increments → press SELECT to exit → kill and relaunch → confirm new value persisted
  • Start the clock, pause mid-game → long-press SELECT → up/down should move in 1-second increments → exit should not change the default
  • Let clock run to 0 (auto-reset to default) → long-press SELECT → should behave as coarse mode (1-minute steps, saves default)

…ver started

Previously the coarse-grained edit mode (60s steps, saves new default) was
gated on game_clock_ever_started() == false. Now it activates whenever the
current time equals the default, which is the more intuitive condition for
'clock is at its starting point'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant