fix(ios): restore compatibility with versions before iOS 26 - #184
Merged
Conversation
4 tasks
otech47
pushed a commit
to fedixyz/fedi
that referenced
this pull request
Aug 18, 2026
## Description - ref fedibtc/product-delivery#50 - since nightly build 262060211 (2026-07-25), iOS kills the app the moment you tap the icon on any iPhone running iOS 15, 16 or 17. no splash, no error dialog from us, every launch. the build before it, 262050209, is fine. release/26.8 has the same bug - #11757 moved the fedimint pin. that took iroh from 0.96 to 1.0, netwatch to 0.19, and netdev to 0.45. netdev 0.45 declares `nw_path_is_ultra_constrained` in an extern block. Apple ships that symbol from iOS 18.1, so dyld cannot bind it on older iOS and kills the process before `main`. our deployment target is 15.1 - upstream removed the binding in netdev 0.46.1 (shellrow/netdev#184), but netwatch 0.19.1 requires `^0.45.0` and cargo will not resolve 0.46. the first commit pins netdev to that same upstream commit cherry-picked onto 0.45.0 in a fedibtc mirror. only the netdev source line moves in `Cargo.lock`. the pin comes out once netwatch releases with 0.46 (n0-computer/net-tools#207, PR n0-computer/net-tools#208) - the second commit makes `build-bridge-ios.sh` fail if any built `libfediffi.a` imports a Network.framework symbol newer than the deployment target. the denylist is every such function defined on the iOS 18.1 simulator runtime and absent on 15.5, generated from Apple's binaries, so it catches the next symbol and not only this one. it runs for the simulator targets too, so a dev machine trips before TestFlight does - this is a different bug from the A7-A10 crash in #11614 and #11601. that one is a CPU instruction and needs an iPhone 7 to reproduce. this one is a missing symbol and reproduces on the iOS 15.5 simulator ## Testing - `nw_path_is_ultra_constrained` is defined in the iOS 18.1 simulator runtime and absent from 15.5, 17.0 and 17.5, checked with `nm` on Network.framework and libnetwork.dylib - the guard fails on a static lib compiled to import that symbol and passes one that imports only iOS 15 APIs - TestFlight build with the pin: run 32081869816 ## Impact on native/web parity - native only. web does not link the bridge ## QA Testing Guidance - install the TestFlight build from run 32081869816 on an iPhone on iOS 15, 16 or 17. it should reach the splash and the wallet. every build since 262060211 crashes on tap - iOS 17 is the most useful check. it was never in the original report and is affected the same way - backport to release/26.8 follows once this merges. 26.8 does not ship without it source commit: 1cce807eec21c47d6b9ec5e32fe5c1fd3ad96873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.