Point the start-image guidance at options.inputSrc and the models that take one - #132
Closed
dazzatronus wants to merge 1 commit into
Closed
Point the start-image guidance at options.inputSrc and the models that take one#132dazzatronus wants to merge 1 commit into
dazzatronus wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #133 — same commit on a branch name without internal references. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three places tell people to do something the API now rejects, or describe behaviour the default model does not have.
The ImageToVideoAsset deprecation notice pointed at "VideoAsset with
promptandinputSrc". That was always loose —inputSrcis never a root VideoAsset property, onlyoptions.inputSrc— and since seedance stopped accepting a start image it names a migration the default model refuses. It now namesshotstack-itv-miniand the right location.The two VideoAsset descriptions said
optionsincludes a starting image, full stop. True forshotstack-itv-miniand the ray models, not for the default.The smoke test paired
seedance-2.0withoptions.inputSrc. It passes either way — the generated Zod treatsoptionsas an open object — so it was not going to go red, just teach the wrong thing.Descriptions only; no schema shape changes.
Verify:
pnpm buildregenerates cleanly and all 71 smoke tests pass. Needs Node 22 locally — this repo has nopackageManagerpin, so corepack falls through to a system pnpm requiring >=22.13.https://linear.app/shotstack/issue/ENG-895