Skip to content

Add 4 construct rows for characteristics with no coverage id#465

Open
johnml1135 wants to merge 1 commit into
conformance-frameworkfrom
g9-add-missing-construct-rows
Open

Add 4 construct rows for characteristics with no coverage id#465
johnml1135 wants to merge 1 commit into
conformance-frameworkfrom
g9-add-missing-construct-rows

Conversation

@johnml1135

@johnml1135 johnml1135 commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • PanGloss's pg-foma::conformance_coverage cross-check maps every CharacteristicKind to one or more constructs.txt identifiers. Four characteristics had no corresponding row at all, so no fixture could ever be written to exercise them by name: rewrite-rule directionality (left-to-right / right-to-left), phonological subrule-level MPR/POS gating, and stratification across more than one CharacterDefinitionTable.
  • Adds one new row per characteristic, next to the closest existing related rows, in the file's existing plain-line style. No renumbering or reordering of existing rows.

Detail

  • RewriteRule direction (Dir): left-to-right / RewriteRule direction (Dir): right-to-left — the existing RewriteRule Iterative/RewriteRule Simultaneous rows tag application order, not directionality; no row named direction as its own phenomenon.
  • RewriteSubruleDef gating: required/excluded POS or MPR at the subrule level — the existing MPR features/groups row is morphological MprGroup territory (MprGroupAppend/MprGroupOverwrite); this is the distinct phonological-subrule gate.
  • CharacterDefinitionTable: more than one table, one per stratum — the two existing CharacterDefinitionTable rows are about segmentation/pattern constructs within one table, not about multiple tables potentially disagreeing across strata.

Test plan

  • Format matches the file's existing convention (one construct per line, no header changes)
  • CI (if any) on this branch

🤖 Generated with Claude Code


This change is Reviewable

conformance_coverage.rs's mapping (machine-consuming PanGloss repo) found
4 CharacteristicKind values -- rewrite direction (LeftToRightRewrite/
RightToLeftRewrite), phonological subrule-level MPR/POS gating
(SubruleGating), and multi-CharacterDefinitionTable stratification
(MultiTable) -- with no constructs.txt row distinctly tagging them, so no
fixture could ever be written to exercise them by name. The existing
"RewriteRule Iterative/Simultaneous" rows tag application-order, not
directionality; "MPR features/groups" is morphological MprGroup territory,
not phonological subrule gating; the two existing CharacterDefinitionTable
rows are about segmentation/pattern constructs within one table, not about
multiple tables disagreeing across strata.

Add one row per characteristic so each can be evidenced independently.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.34%. Comparing base (dd8f95c) to head (4560e9e).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           conformance-framework     #465   +/-   ##
======================================================
  Coverage                  73.34%   73.34%           
======================================================
  Files                        443      443           
  Lines                      37214    37214           
  Branches                    5110     5110           
======================================================
  Hits                       27294    27294           
  Misses                      8798     8798           
  Partials                    1122     1122           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants