Add 4 construct rows for characteristics with no coverage id#465
Open
johnml1135 wants to merge 1 commit into
Open
Add 4 construct rows for characteristics with no coverage id#465johnml1135 wants to merge 1 commit into
johnml1135 wants to merge 1 commit into
Conversation
conformance_coverage.rs's mapping (machine-consuming PanGloss repo) found 4 CharacteristicKind values -- rewrite direction (LeftToRightRewrite/ RightToLeftRewrite), phonological subrule-level MPR/POS gating (SubruleGating), and multi-CharacterDefinitionTable stratification (MultiTable) -- with no constructs.txt row distinctly tagging them, so no fixture could ever be written to exercise them by name. The existing "RewriteRule Iterative/Simultaneous" rows tag application-order, not directionality; "MPR features/groups" is morphological MprGroup territory, not phonological subrule gating; the two existing CharacterDefinitionTable rows are about segmentation/pattern constructs within one table, not about multiple tables disagreeing across strata. Add one row per characteristic so each can be evidenced independently.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## conformance-framework #465 +/- ##
======================================================
Coverage 73.34% 73.34%
======================================================
Files 443 443
Lines 37214 37214
Branches 5110 5110
======================================================
Hits 27294 27294
Misses 8798 8798
Partials 1122 1122 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg-foma::conformance_coveragecross-check maps everyCharacteristicKindto one or moreconstructs.txtidentifiers. Four characteristics had no corresponding row at all, so no fixture could ever be written to exercise them by name: rewrite-rule directionality (left-to-right / right-to-left), phonological subrule-level MPR/POS gating, and stratification across more than oneCharacterDefinitionTable.Detail
RewriteRule direction (Dir): left-to-right/RewriteRule direction (Dir): right-to-left— the existingRewriteRule Iterative/RewriteRule Simultaneousrows tag application order, not directionality; no row named direction as its own phenomenon.RewriteSubruleDef gating: required/excluded POS or MPR at the subrule level— the existingMPR features/groupsrow is morphologicalMprGroupterritory (MprGroupAppend/MprGroupOverwrite); this is the distinct phonological-subrule gate.CharacterDefinitionTable: more than one table, one per stratum— the two existingCharacterDefinitionTablerows are about segmentation/pattern constructs within one table, not about multiple tables potentially disagreeing across strata.Test plan
🤖 Generated with Claude Code
This change is