Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TOP mode to --folder-as-album: fits nicely in already taken convention of specifying mode by name.
Adds a third value alongside FOLDER and PATH: TOP names the album after the top-level folder, so every asset below it, however deeply nested, lands in a single album rather than one album per leaf directory.
The album name is the first path segment relative to the folder given on the command line; files sitting directly in that folder use its own name, matching what FOLDER already does for the same case.
Previously this grouping was only reachable by invoking immich-go once per top-level folder with --into-album, which re-scanned and reconnected for each one.
The new value is accepted by AlbumFolderMode.Set, so it works from the command line, the configuration file and the IMMICH_GO_* environment variables alike. Documentation updated wherever the accepted values are listed.
Adds adapters/folder/folderCli_test.go covering flag parsing and text round-tripping - the first test file in this package.