Html api commoncrawl

.github/workflows/coding-standards.yml

@@ -8,11 +8,6 @@ on:
       - trunk
       - '3.[89]'
       - '[4-9].[0-9]'
-    tags:
-      - '3.[89]'
-      - '3.[89].[0-9]+'
-      - '[4-9].[0-9]'
-      - '[4-9].[0-9].[0-9]+'
   pull_request:
     branches:
       - trunk

.github/workflows/end-to-end-tests.yml

@@ -7,11 +7,6 @@ on:
       - trunk
       - '5.[3-9]'
       - '[6-9].[0-9]'
-    tags:
-      - '5.[3-9]'
-      - '5.[3-9].[0-9]+'
-      - '[6-9]+.[0-9]'
-      - '[6-9]+.[0-9].[0-9]+'
   pull_request:
     branches:
       - trunk

.github/workflows/javascript-tests.yml

@@ -7,11 +7,6 @@ on:
       - trunk
       - '3.[89]'
       - '[4-9].[0-9]'
-    tags:
-      - '3.[89]'
-      - '3.[89].[0-9]+'
-      - '[4-9].[0-9]'
-      - '[4-9].[0-9].[0-9]+'
   pull_request:
     branches:
       - trunk

.github/workflows/javascript-type-checking.yml

@@ -6,9 +6,6 @@ on:
     branches:
       - trunk
       - '[7-9].[0-9]'
-    tags:
-      - '[7-9].[0-9]'
-      - '[7-9]+.[0-9].[0-9]+'
   pull_request:
     branches:
       - trunk

.github/workflows/performance.yml

@@ -7,11 +7,6 @@ on:
       - trunk
       - '6.[2-9]'
       - '[7-9].[0-9]'
-    tags:
-      - '6.[2-9]'
-      - '6.[2-9].[0-9]+'
-      - '[7-9].[0-9]'
-      - '[7-9].[0-9].[0-9]+'
   pull_request:
     branches:
       - trunk

.github/workflows/php-compatibility.yml

@@ -7,11 +7,6 @@ on:
       - trunk
       - '5.[5-9]'
       - '[6-9].[0-9]'
-    tags:
-      - '5.[5-9]'
-      - '5.[5-9].[0-9]+'
-      - '[6-9].[0-9]'
-      - '[6-9].[0-9].[0-9]+'
   pull_request:
     branches:
       - trunk

.github/workflows/phpstan-static-analysis.yml

@@ -6,9 +6,6 @@ on:
     branches:
       - trunk
       - '[7-9].[0-9]'
-    tags:
-      - '[7-9].[0-9]'
-      - '[7-9]+.[0-9].[0-9]+'
   pull_request:
     branches:
       - trunk
@@ -21,7 +18,7 @@ on:
       # These files configure PHPStan. Changes could affect the outcome.
       - 'phpstan.neon.dist'
       - 'tests/phpstan/base.neon'
-      - 'tests/phpstan/baseline.php'
+      - 'tests/phpstan/baselines/**'
       # Confirm any changes to relevant workflow files.
       - '.github/workflows/phpstan-static-analysis.yml'
       - '.github/workflows/reusable-phpstan-static-analysis-v1.yml'

.github/workflows/phpunit-tests.yml

@@ -6,9 +6,6 @@ on:
       - trunk
       - '3.[7-9]'
       - '[4-9].[0-9]'
-    tags:
-      - '[0-9]+.[0-9]'
-      - '[0-9]+.[0-9].[0-9]+'
   pull_request:
     branches:
       - trunk
@@ -37,6 +34,7 @@ on:
       # Confirm any changes to relevant workflow files.
       - '.github/workflows/phpunit-tests.yml'
       - '.github/workflows/reusable-phpunit-tests-*.yml'
+      - '.github/workflows/reusable-prepare-gutenberg.yml'
   workflow_dispatch:
   # Once weekly On Sundays at 00:00 UTC.
   schedule:
@@ -54,6 +52,20 @@ concurrency:
 permissions: {}
 
 jobs:
+  # Downloads and verifies the Gutenberg build once for all PHPUnit jobs.
+  #
+  # This condition is the union of the conditions on the jobs that need it, reduced.
+  # The org matrices require `WordPress/wordpress-develop` or a pull request, and the
+  # fork matrix requires a pull request, so `wordpress-develop` or a pull request
+  # covers every case. Keep it in step with those jobs: a narrower condition orphans
+  # them, because a job that needs a skipped job is skipped too, and a broader one
+  # downloads a build that nothing consumes.
+  prepare-gutenberg:
+    uses: ./.github/workflows/reusable-prepare-gutenberg.yml
+    permissions:
+      contents: read
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+
   #
   # Creates a PHPUnit test job for each PHP/MySQL combination.
   #
@@ -64,6 +76,7 @@ jobs:
   test-with-mysql:
     name: PHP ${{ matrix.php }}
     uses: ./.github/workflows/reusable-phpunit-tests-v3.yml
+    needs: prepare-gutenberg
     permissions:
       contents: read
     secrets:
@@ -74,7 +87,8 @@ jobs:
       fail-fast: false
       matrix:
         os: [ ubuntu-24.04 ]
-        php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
+        # The scheduled run tests every supported PHP version. Other events test the highest and lowest of each major.
+        php: ${{ github.event_name == 'schedule' && fromJSON('["7.4","8.0","8.1","8.2","8.3","8.4","8.5"]') || fromJSON('["7.4","8.0","8.5"]') }}
         db-type: [ 'mysql' ]
         db-version: [ '5.7', '8.0', '8.4', '9.7' ]
         tests-domain: [ 'example.org' ]
@@ -130,6 +144,8 @@ jobs:
       phpunit-config: ${{ matrix.multisite && 'tests/phpunit/multisite.xml' || 'phpunit.xml.dist' }}
       tests-domain: ${{ matrix.tests-domain }}
       report: ${{ matrix.report || false }}
+      gutenberg-artifact: gutenberg-build
+      gutenberg-sha: ${{ needs.prepare-gutenberg.outputs.gutenberg-sha }}
 
   #
   # Creates a PHPUnit test job for each PHP/MariaDB combination.
@@ -143,6 +159,7 @@ jobs:
   test-with-mariadb:
     name: PHP ${{ matrix.php }}
     uses: ./.github/workflows/reusable-phpunit-tests-v3.yml
+    needs: prepare-gutenberg
     permissions:
       contents: read
     secrets:
@@ -153,7 +170,8 @@ jobs:
       fail-fast: false
       matrix:
         os: [ ubuntu-24.04 ]
-        php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
+        # The scheduled run tests every supported PHP version. Other events test the highest and lowest of each major.
+        php: ${{ github.event_name == 'schedule' && fromJSON('["7.4","8.0","8.1","8.2","8.3","8.4","8.5"]') || fromJSON('["7.4","8.0","8.5"]') }}
         db-type: [ 'mariadb' ]
         db-version: [ '5.5', '10.3', '10.5', '10.6', '10.11', '11.4', '11.8' ]
         multisite: [ false, true ]
@@ -182,6 +200,8 @@ jobs:
       memcached: ${{ matrix.memcached }}
       phpunit-config: ${{ matrix.multisite && 'tests/phpunit/multisite.xml' || 'phpunit.xml.dist' }}
       report: false
+      gutenberg-artifact: gutenberg-build
+      gutenberg-sha: ${{ needs.prepare-gutenberg.outputs.gutenberg-sha }}
 
   #
   # Creates PHPUnit test jobs to test MariaDB and MySQL innovation releases.
@@ -197,6 +217,7 @@ jobs:
   test-innovation-releases:
     name: PHP ${{ matrix.php }}
     uses: ./.github/workflows/reusable-phpunit-tests-v3.yml
+    needs: prepare-gutenberg
     permissions:
       contents: read
     secrets:
@@ -207,7 +228,8 @@ jobs:
       fail-fast: false
       matrix:
         os: [ ubuntu-24.04 ]
-        php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
+        # The scheduled run tests every supported PHP version. Other events test the highest and lowest of each major.
+        php: ${{ github.event_name == 'schedule' && fromJSON('["7.4","8.0","8.1","8.2","8.3","8.4","8.5"]') || fromJSON('["7.4","8.0","8.5"]') }}
         db-type: [ 'mysql', 'mariadb' ]
         db-version: [ '12.1' ]
         multisite: [ false, true ]
@@ -228,6 +250,8 @@ jobs:
       memcached: ${{ matrix.memcached }}
       phpunit-config: ${{ matrix.multisite && 'tests/phpunit/multisite.xml' || 'phpunit.xml.dist' }}
       report: false
+      gutenberg-artifact: gutenberg-build
+      gutenberg-sha: ${{ needs.prepare-gutenberg.outputs.gutenberg-sha }}
 
   #
   # Runs the HTML API test group.
@@ -240,6 +264,7 @@ jobs:
   html-api-test-groups:
     name: ${{ matrix.label }}
     uses: ./.github/workflows/reusable-phpunit-tests-v3.yml
+    needs: prepare-gutenberg
     permissions:
       contents: read
     secrets:
@@ -260,6 +285,8 @@ jobs:
       db-type: ${{ matrix.db-type }}
       db-version: ${{ matrix.db-version }}
       phpunit-test-groups: ${{ matrix.phpunit-test-groups }}
+      gutenberg-artifact: gutenberg-build
+      gutenberg-sha: ${{ needs.prepare-gutenberg.outputs.gutenberg-sha }}
 
   #
   # Runs unit tests for forks.
@@ -271,6 +298,7 @@ jobs:
   limited-matrix-for-forks:
     name: PHP ${{ matrix.php }}
     uses: ./.github/workflows/reusable-phpunit-tests-v3.yml
+    needs: prepare-gutenberg
     permissions:
       contents: read
     secrets:
@@ -318,16 +346,20 @@ jobs:
       php: ${{ matrix.php }}
       db-version: ${{ matrix.db-version }}
       db-type: ${{ matrix.db-type }}
+      multisite: ${{ matrix.multisite }}
       memcached: ${{ matrix.memcached || false }}
+      phpunit-config: ${{ matrix.multisite && 'tests/phpunit/multisite.xml' || 'phpunit.xml.dist' }}
       phpunit-test-groups: ${{ matrix.phpunit-test-groups || '' }}
+      gutenberg-artifact: gutenberg-build
+      gutenberg-sha: ${{ needs.prepare-gutenberg.outputs.gutenberg-sha }}
 
   slack-notifications:
     name: Slack Notifications
     uses: ./.github/workflows/slack-notifications.yml
     permissions:
       actions: read
       contents: read
-    needs: [ test-with-mysql, test-with-mariadb, test-innovation-releases, html-api-test-groups, limited-matrix-for-forks ]
+    needs: [ prepare-gutenberg, test-with-mysql, test-with-mariadb, test-innovation-releases, html-api-test-groups, limited-matrix-for-forks ]
     if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     with:
       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}

.github/workflows/reusable-phpstan-static-analysis-v1.yml

@@ -32,6 +32,7 @@ jobs:
   # - Builds WordPress.
   # - Configures caching for PHPStan static analysis scans.
   # - Runs PHPStan static analysis (with Pull Request annotations).
+  # - Checks whether the baselines need regenerating.
   # - Saves the PHPStan result cache.
   # - Ensures version-controlled files are not modified or deleted.
   phpstan:
@@ -93,7 +94,99 @@ jobs:
 
       - name: Run PHP static analysis tests
         id: phpstan
-        run: composer run phpstan -- -vvv --error-format=checkstyle | cs2pr --errors-as-warnings --graceful-warnings
+        run: |
+          # The report is written to a file as well as piped to cs2pr, so that the step below
+          # can look at it.
+          #
+          # cs2pr exits successfully so that reported errors annotate the pull request without
+          # failing the run. A pipeline reports only the status of its last command, so that
+          # also discards the status of the analysis itself. Recover it from PIPESTATUS.
+          composer run phpstan -- -vvv --error-format=checkstyle | tee "${RUNNER_TEMP}/phpstan-report.xml" | cs2pr --errors-as-warnings --graceful-warnings
+          status="${PIPESTATUS[0]}"
+
+          # PHPStan exits 1 when it has errors to report, which is the expected case here and
+          # is what the annotations are for. Anything higher means it did not finish at all,
+          # which would otherwise pass silently, since the discarded status was the only sign.
+          if [ "${status}" -gt 1 ]; then
+            echo "::error title=PHPStan did not complete::The analysis exited with status ${status}, so the code was not fully checked. This is a failure of the run itself rather than a problem found in the code."
+            exit "${status}"
+          fi
+
+      # An ignored error that no longer occurs, or occurs a different number of times, is
+      # reported under an `ignore.*` identifier. That is not something to fix in the code: the
+      # usual cause is that the error *was* fixed, leaving a baseline describing a state that
+      # no longer exists. PHPStan does not allow those reports to be ignored or baselined.
+      #
+      # The analysis above is reported as warnings, so this would otherwise surface as a
+      # passing run carrying an annotation that reads like a complaint about a fix. Call it
+      # out on its own, and say what to do about it.
+      #
+      # Detection is on the identifier rather than the message, which is prose and may be
+      # reworded in any release. The checkstyle format carries it in the `source` attribute.
+      - name: Check whether the baselines need regenerating
+        if: ${{ !cancelled() }}
+        env:
+          BASELINES_URL: ${{ github.server_url }}/${{ github.repository }}/tree/${{ github.sha }}/tests/phpstan/baselines
+          README_URL: ${{ github.server_url }}/${{ github.repository }}/blob/${{ github.sha }}/tests/phpstan/README.md
+        run: |
+          # This step runs even when the analysis above it failed, in which case the report may
+          # never have been written. That failure is reported there, so there is nothing to add
+          # here beyond staying quiet about a file that was never going to exist.
+          if [ ! -f "${RUNNER_TEMP}/phpstan-report.xml" ]; then
+            exit 0
+          fi
+
+          # Leave the run alone unless PHPStan reported an ignore error, because everything
+          # below concerns an ignore configuration that no longer describes the code, and
+          # nothing else. Those errors are `ignore.unmatched`, where a pattern matched nothing
+          # at all, and `ignore.count`, where it matched a different number of times than the
+          # entry records. The `ignore.` prefix is matched rather than those two names so that
+          # any later addition to the group is caught as well.
+          if ! grep -q 'source="ignore\.' "${RUNNER_TEMP}/phpstan-report.xml"; then
+            exit 0
+          fi
+
+          # The summary is Markdown, and its code spans and fences are written literally, so the
+          # heredoc is quoted to keep the backticks out of the shell's hands. The links are
+          # written in reference style for the same reason: the URLs are the only part needing
+          # a variable, so defining them afterwards keeps the whole of the prose in here.
+          #
+          # A newline renders as a line break rather than a space, so each paragraph is one
+          # line however long that makes it, and the rendered summary wraps to its own width.
+          cat >> "${GITHUB_STEP_SUMMARY}" <<'SUMMARY'
+          ## PHPStan baselines are out of date
+
+          An ignored error no longer occurs, or occurs a different number of times, so PHPStan reported it under an `ignore.unmatched` or `ignore.count` identifier.
+
+          **If you fixed the error, this is expected.** Each baseline entry records an exact count for a specific file, so that a new occurrence of an already baselined error is reported rather than absorbed. That same exactness means fixing one leaves the baseline describing a state that no longer exists. There is nothing to fix in the code; the baselines just need to catch up.
+
+          Regenerate them and commit the result:
+
+          ```bash
+          npm run typecheck:php:baselines
+          ```
+
+          or, outside the Docker environment:
+
+          ```bash
+          composer phpstan:baselines
+          ```
+
+          That rewrites the files under [`tests/phpstan/baselines`][baselines], deletes any whose errors are now all fixed, and updates the list of them in `phpstan.neon.dist`.
+
+          Where the report names an `@phpstan-ignore` annotation in the code rather than a baseline entry, remove that annotation instead; regenerating will not clear it.
+
+          See [`tests/phpstan/README.md`][readme] for details.
+
+          SUMMARY
+
+          {
+            echo "[baselines]: ${BASELINES_URL}"
+            echo "[readme]: ${README_URL}"
+          } >> "${GITHUB_STEP_SUMMARY}"
+
+          echo "::error title=PHPStan baselines are out of date::An ignored error no longer occurs, or occurs a different number of times. If you fixed it, that is expected: run \`npm run typecheck:php:baselines\` or \`composer phpstan:baselines\` and commit the updated baselines. See ${README_URL}"
+          exit 1
 
       - name: "Save result cache"
         uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5