fix(qbit): respect hashes when changing torrent categories - #418
Open
luigibarretta wants to merge 1 commit into
Open
luigibarretta wants to merge 1 commit into
luigibarretta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qBittorrent setCategory handler builds a hash set but never assigns filterFunc. UpdateWhere therefore receives nil and changes every queued entry, including torrents not selected by the client.
This patch supplies an explicit hash predicate, supports pipe-delimited and repeated hashes, matches hashes case-insensitively, and requires an explicit all value for whole-queue changes. Missing or ambiguous hashes return HTTP 400.
Regression tests cover one/multiple/unknown hashes, explicit all, missing input, ambiguous input, and preservation of unselected storage rows and their paths. Verified with go test -p 2 ./pkg/server/qbit against current main 0dd1cbb.
No changes to delete, pause/resume, data format or dependencies. The same fix has been exercised in a private deployment with per-row queue verification. AI-assisted contribution, reviewed and tested before submission.