Require solid 2.0.0-rc.7; drop the async render head-commit workaround - #350
Open
ryansolid wants to merge 1 commit into
Open
Require solid 2.0.0-rc.7; drop the async render head-commit workaround#350ryansolid wants to merge 1 commit into
ryansolid wants to merge 1 commit into
Conversation
|
| Name | Type |
|---|---|
| @solidjs/vite-plugin | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
rc.7 (solidjs/solid#3292) freezes the response head when an awaited renderToStream completes, before the render is disposed, so the generated SSR entry no longer needs to commit the stub from onCompleteAll and authored entries need no hook. Peer floors move to ^2.0.0-rc.7; README caveat and the unreleased render-mode changeset drop the workaround wording. Against rc.6 the render-mode suite fails exactly the six async head assertions (status/header/Location, dev+prod); the rc.7 ride commit (catalog + lockfile + minimumReleaseAgeExclude) turns them green. Co-authored-by: Cursor <cursoragent@cursor.com>
ryansolid
marked this pull request as ready for review
September 6, 2026 06:37
ryansolid
force-pushed
the
require-solid-rc7
branch
from
September 6, 2026 06:37
6ec0d96 to
bfca1a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to solidjs/solid#3292, which makes `@solidjs/web` freeze the response head when an awaited `renderToStream` completes (before the render owner is disposed). The plugin-side workaround from #349 never shipped, so it is simply removed rather than deprecated:
No plugin release is cut before rc.7, so this lands together with the rc.7 ride commit (workspace catalog → `^2.0.0-rc.7`, lockfile, `minimumReleaseAgeExclude` entries) once rc.7 is on npm, and the pending Version Packages PR picks it all up as one release. Until then, against rc.6 the `render-mode` suite fails exactly the six async head assertions (`httpStatus(404)`, `httpHeader`, pre-flush `Location` × dev/prod; 114/120 otherwise) — the behaviour this PR intentionally hands back to the runtime.