Skip to content

fix(web): render textarea spread values as content - #3287

Merged
ryansolid merged 1 commit into
solidjs:nextfrom
javascript-unsafe:fix/ssr-textarea-spread-value-3286
Sep 6, 2026
Merged

fix(web): render textarea spread values as content#3287
ryansolid merged 1 commit into
solidjs:nextfrom
javascript-unsafe:fix/ssr-textarea-spread-value-3286

Conversation

@javascript-unsafe

@javascript-unsafe javascript-unsafe commented Sep 5, 2026

Copy link
Copy Markdown

Summary

  • Render textarea value and defaultValue props from SSR spreads as text content.
  • Keep the SSR runtime path aligned with compiler-specialized textarea output.
  • Cover declared and spread-supplied values in both attribute orderings.

Test plan

  • pnpm --dir packages/web exec vitest run --config vite.config.server.mjs
  • pnpm --dir packages/web exec vitest run --config vite.config.hydrate.mjs
  • pnpm --dir packages/web exec vitest run
  • JSX_COMPILER=babel pnpm --dir packages/web exec vitest run --config vite.config.server.mjs test/server/spread-function-source.spec.tsx

@changeset-bot

changeset-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4f159e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@solidjs/web Patch
@solidjs/babel-plugin Patch
@solidjs/element Patch
@solidjs/h Patch
@solidjs/html Patch
test-integration Patch
@solidjs/compiler Patch
@solidjs/diagnostics Patch
@solidjs/signals Patch
solid-js Patch
@solidjs/universal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq

codspeed-hq Bot commented Sep 5, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 136 untouched benchmarks


Comparing javascript-unsafe:fix/ssr-textarea-spread-value-3286 (4f159e3) with next (b1b38c3)

Open in CodSpeed

@ryansolid
ryansolid force-pushed the fix/ssr-textarea-spread-value-3286 branch from c5477e6 to 4f159e3 Compare September 6, 2026 08:49
@ryansolid
ryansolid merged commit b64071c into solidjs:next Sep 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants