[doc]: Clarify HFT enterprise number layout - #2537
Merged
Pterosaur merged 1 commit intoSep 5, 2026
Merged
Conversation
Signed-off-by: Ze Gan <ganze718@gmail.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
DavidZagury
approved these changes
Sep 4, 2026
Pterosaur
added a commit
to opencomputeproject/SAI
that referenced
this pull request
Sep 5, 2026
What I did Clarified the HFT IPFIX enterprise-number wire layout and corrected the example value: the first 16 bits on the wire encode the SAI object type; the following 16 bits encode the SAI stats ID; multi-byte values use network byte order. For queue type 0x0015 and stat ID 0x0022, this gives 0x00150022, or wire bytes 00 15 00 22. Why I did it The previous formula placed the stat ID in the high 16 bits and contradicted both the adjacent bit diagram and the current SONiC countersyncd HFT IPFIX decoder. How I verified it This is a one-line documentation correction. git diff --check passes and the old example value no longer appears in the document. The matching sonic-net/SONiC HLD change is submitted separately. Matching SONiC HLD PR: sonic-net/SONiC#2537 Signed-off-by: Ze Gan <ganze718@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Clarified the HFT IPFIX enterprise-number wire layout and corrected the example value:
For queue type
0x0015and stat ID0x0022, this gives0x00150022, or wire bytes00 15 00 22.Why I did it
The previous formula placed the stat ID in the high 16 bits and contradicted both the adjacent bit diagram and the current countersyncd HFT IPFIX decoder.
How I verified it
This is a one-line documentation correction.
git diff --checkpasses and the old example value no longer appears in the HLD.The matching OCP SAI documentation change is submitted separately.
Matching OCP SAI PR: opencomputeproject/SAI#2346