[CPO] Add aggregate methods to ElsfpApi - #752
Open
bgallagher-nexthop wants to merge 12 commits into
Open
Conversation
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
bgallagher-nexthop
marked this pull request as ready for review
September 3, 2026 00:04
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
nh-grecs Bot
pushed a commit
to nexthop-ai/sonic-platform-common
that referenced
this pull request
Sep 3, 2026
rebuild-source: sonic-net#752 @ nexthop-ai/sonic-platform-common f8defa8 [case: upstream:open]
nh-grecs Bot
pushed a commit
to nexthop-ai/sonic-platform-common
that referenced
this pull request
Sep 3, 2026
rebuild-source: sonic-net#752 @ nexthop-ai/sonic-platform-common f8defa8 [case: upstream:open]
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
… works out-of-the-box Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
…alues names Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
…s aggregate methods Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
nh-grecs Bot
pushed a commit
to nexthop-ai/sonic-platform-common
that referenced
this pull request
Sep 5, 2026
rebuild-source: sonic-net#752 @ nexthop-ai/sonic-platform-common 2c79f79 [case: upstream:open]
nh-grecs Bot
pushed a commit
to nexthop-ai/sonic-platform-common
that referenced
this pull request
Sep 5, 2026
rebuild-source: sonic-net#752 @ nexthop-ai/sonic-platform-common 2c79f79 [case: upstream:open]
nh-grecs Bot
pushed a commit
to nexthop-ai/sonic-platform-common
that referenced
this pull request
Sep 7, 2026
rebuild-source: sonic-net#752 @ nexthop-ai/sonic-platform-common 2c79f79 [case: upstream:open]
nh-grecs Bot
pushed a commit
to nexthop-ai/sonic-platform-common
that referenced
this pull request
Sep 7, 2026
rebuild-source: sonic-net#752 @ nexthop-ai/sonic-platform-common 2c79f79 [case: upstream:open]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds aggregate methods in
ElsfpApithat read multiple registers and return a dictionary of logically grouped information to xcvrd. A set of methods analagous to the aggregate methods inCmisApiare implemented:get_elsfp_infoget_elsfp_info_firmware_versionsget_elsfp_dom_real_valueget_elsfp_dom_flagsget_elsfp_threshold_infoget_elsfp_status_flagsget_elsfp_statusEach aggregate method has a variant that fetches only banked or non-banked information, where appropriate.
Motivation and Context
This change is required to enable
xcvrdto call convenient aggregate methods to attain the information it wants to read from hardware. This follows the pre-established conventionxcvrdfollows when reading from hardware.How Has This Been Tested?
Unit-tests have been added.
Additional Information (Optional)