Refactor and Improve MusicKit Application - #2
Conversation
…layer - Redesigned UI applying 'Liquid Glass' theme with soft shadows and translucency - Added support for standard audio files (.mp3, .flac) to the scanner - Migrated lyrics fetching to a flexible LyricsManager with LrcLib and NetEase providers - Implemented TagEditorPage for metadata modification utilizing TagLib - Created an independent PlayerLyricsPage with synchronized scrolling and blurred backgrounds - Resolved race conditions in the MediaPlayer lifecycle - Resolved NCM converter regression with specific file-type matching Co-authored-by: sorrow404Null <145167297+sorrow404Null@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Carefully analyzed the whole codebase and implemented the major requirements.
Theme.kt,SettingsPage.kt,HomePage.ktandNcmSongItem.ktto achieve the "Liquid Glass" theme aesthetic without over-decorating..mp3and.flac. Added a type enumFileTypeto distinguish between formats, preventing standard audio files from being accidentally fed into the NCM converter.TagEditorPagebacked byTagEditorViewModelwhich uses theTagLibC++ bridge library to read, preserve, and cleanly rewrite metadata strings in ID3 formats.LyricsManagersupportingNetEaseLyricsProviderand a newLrcLibLyricsProviderhitting a public web API for reliable synced.lrcfallback options.PlayerLyricsPagefunctioning with nativeMediaPlayer. It handles the coroutine IO thread elegantly, provides standard playback controls, presents synchronized scrolling lyrics, and renders the currently playing song's cover art as a deeply blurred, full-screen background effect.PR created automatically by Jules for task 760254517624238374 started by @sorrow404Null