fix(proxy): reject conflicting multi-instance admin options - #17
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c9b28f36a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if webSet && out.webLogMax != opt.webLogMax { | ||
| return out, errors.New(i18n.T(i18n.KeyErrConflictingMultiOption, "web_log_max", out.webLogMax, opt.webLogMax)) |
There was a problem hiding this comment.
When multiple proxy entries repeat the same web_addr, an entry that omits web_log_max has already been expanded to the default 1000 before this comparison. Consequently, a valid configuration where one entry omits the setting and another explicitly sets (for example) 200 is rejected as a 1000-vs-200 conflict, preventing the proxy from starting. Preserve whether ProxyConfig.WebLogMax was explicitly provided and only treat differing explicit capacities as conflicts, as the forward multi-instance collector already does.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Why
Multi-instance proxy processes expose one shared stats endpoint and one shared Web panel. Silently selecting the first declaration made security and observability behavior depend on YAML ordering, including whether an endpoint was publicly exposed.
Validation
Existing CI plus new unit coverage exercises address,
allow_public, andweb_log_maxconsolidation.