Skip to content

warn that speaker id is unsupported for batch cpu mode - #306

Open
dln22 wants to merge 4 commits into
speechmatics:mainfrom
dln22:add-speaker-id-unsupported-on-batch-cpu-note
Open

warn that speaker id is unsupported for batch cpu mode#306
dln22 wants to merge 4 commits into
speechmatics:mainfrom
dln22:add-speaker-id-unsupported-on-batch-cpu-note

Conversation

@dln22

@dln22 dln22 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

This PR adds a warning that the SpeakerID feature is unsupported for Batch CPU mode.

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Speechmatics Team on Vercel.

A member of the Team first needs to authorize it.

@petemomo petemomo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against the docs style guide, terminology, and the product-architecture context, and verified all four changes in a local build.

Solid, focused change — the limitation is stated consistently in substance across all four pages, cross-links are correct, every internal link resolves, and the warning body plus the deployments-table footnote both render correctly.

Main thing to know: the warning's custom title doesn't render (details inline) — but that's a pre-existing gap in the swizzled Admonition component, not something this PR introduced, and the body stands alone. The rest are small consistency/style items with suggestions inline. Nothing here blocks merge.

On the core claim (speaker identification unsupported on the CPU batch container, requires GPU, Realtime OK on both): I couldn't verify it against the project reference files (product-architecture.md doesn't cover the CPU/GPU support matrix), but it doesn't conflict with them — accepting on author/SME authority.

Comment thread docs/deployments/container/speaker-identification.mdx Outdated
Comment thread docs/deployments/container/speaker-identification.mdx Outdated
Comment thread docs/deployments/container/batch-persistent-worker.mdx Outdated
Comment thread docs/deployments/index.md Outdated
Comment thread docs/deployments/container/batch-persistent-worker.mdx
@giorgosHadji

Copy link
Copy Markdown
Contributor

LGTM from tech side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants