Skip to content

Remove dead function parameters - #627

Merged
soininen merged 1 commit into
masterfrom
remove_unused_kwargs
Sep 10, 2026
Merged

soininen merged 1 commit into
masterfrom
remove_unused_kwargs

Conversation

@soininen

@soininen soininen commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Removed future=True parameters from SQLAlchemy functions which were helpful when migrating from SQLAlchemy 1.3 to 2.0 but are now effectively dead code.

No functional changes intended.

No associated issue.

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

These were useful when updating from SQLAlchemy 1.3 to 2.0
but are not needed anymore.

No functional changes intended.
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.15%. Comparing base (1e9110b) to head (f8cdf18).

Files with missing lines Patch % Lines
spinedb_api/db_mapping.py 75.00% 1 Missing ⚠️
spinedb_api/helpers.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files          83       83           
  Lines       11477    11477           
  Branches     1636     1636           
=======================================
  Hits         9888     9888           
  Misses       1238     1238           
  Partials      351      351           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soininen
soininen merged commit d5e1139 into master Sep 10, 2026
17 checks passed
@soininen
soininen deleted the remove_unused_kwargs branch September 10, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant