fix(FlagEvaluation): cast value instead of self in getTyped - #271
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
Fixes spotify#252 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
reginaldalfret
requested review from
andreas-karlsson,
fabriziodemaria,
mfranberg,
nicklasl and
vahidlazio
as code owners
October 3, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a type check in
FlagResolution.getTyped(value:defaultValue:)whereselfwas being cast toTinstead of thevalueparameter.Problem
In
Sources/Confidence/FlagEvaluation.swift, line 229 checkedif let value = self as? T. Becauseselfis aFlagResolutionstruct rather than a value type, this conditional cast could never succeed for any requested flag type (String,Int,Double,Bool), causing execution to fall through to the switch statement instead of executing the early return fast-path.Solution
Update
if let value = self as? Ttoif let value = value as? Tto properly evaluate thevalueparameter.Testing
Fixes #252