docs: fix 4 typos in comments and messages - #1376
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 4 small typos/copy-paste errors:
@implicitNotFound("Cannot derive AvroField for sealed trait")->... ValueField .... Copy-paste from the avro module; every other module names its own typeclass here (ProtobufField,TableRowField,ExampleField,EntityField,BigtableField), so the neo4j derivation currently reports the wrong type in the compile error.InvalidRecordExceptionmessage -reader schema$reader``"->reader schema `$reader`"`.// TIMESTAMPheading pointed atdata-types#time_type; changed todata-types#timestamp_type. (The#time_typelink under the// TIMEheading is correct and was left alone.)// TIME (millis i32, micros i64, nanos, i64)->nanos i64(stray comma).Please note one change touches a string literal: the
InvalidRecordExceptionmessage inSchema.scala. No test in the repo asserts on that text (grepped), and the change only removes a duplicated backtick, but flagging it so it gets a second look. Everything else is comments/annotations.No functional changes and no identifiers renamed.