Update magnolify to 0.9.8; adopt portable Timestamp encoding for IcebergIO - #6000
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6000 +/- ##
=======================================
Coverage 61.98% 61.99%
=======================================
Files 323 323
Lines 11743 11743
Branches 839 839
=======================================
+ Hits 7279 7280 +1
+ Misses 4464 4463 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clairemcginty
approved these changes
Sep 17, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IcebergIOITfromlogical.millis._(joda-backedDATETIME) tological.timestamp.micros._(Beam's portableTimestamplogical type at microsecond precision), which is what IcebergIO requires as of Beam 2.76.0LocalDateTime/ unzoned timestamp coverage toIcebergIOIT(from Add unzoned timestamp type test to IcebergIOIT #5999)Context
Beam 2.76.0 changed IcebergIO's
timestamptzmapping fromDATETIMEtoTimestamp.MICROS(apache/beam#39344). With the oldmillis._import, reads now fail withClassCastException: java.time.Instant cannot be cast to org.joda.time.Instant.Magnolify 0.9.8 (spotify/magnolify#1392) adds
logical.timestamp.{millis,micros,nanos}which mapInstantto Beam's portableTimestampat the declared precision. The old encodings remain available underlogical.compat.*; the barelogical.millis/micros/nanosobjects are deprecated aliases that preserve 0.9.7 behavior.Verified locally
All three scenarios tested against a real Iceberg REST catalog container:
timestamp.micros._millis._ClassCastExceptionon readmillis._--updateCompatibilityVersion=2.75.0Test plan
IcebergIOITpasses (already verified locally)