SOD-824: Add scalingOrientation (orientation) field to Ocean AKS VNG strategy - #852
Merged
Conversation
sbeecha
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://flexera.atlassian.net/browse/SOD-824
What
Adds the
orientationfield to the sharedocean-strategy.yamlschema underapi/services/ocean/aks/schemas/, used by thestrategyobject across all 4 Ocean AKS VNG operations (they all $ref the same schema file):oceanAKSVirtualNodeGroupCreate)oceanAKSVirtualNodeGroupGet/oceanAKSVirtualNodeGroupList)oceanAKSVirtualNodeGroupUpdate)oceanAKSVirtualNodeGroupImport)Field
orientation(kept as-is to match the actual field name implemented inspotinst-api/spotinst-azure-ocean-common— the story named itscalingOrientation, but no rename was made in code, so the doc uses the real field name to stay accurate)[cost, availability]costVerification
yarn validate(swagger-cli validate) — passyarn bundle:swagger— passnpx @redocly/cli lint— no new errors/warnings introduced (3 pre-existing errors unrelated to this file)yarn bundle:redocfails on this branch and equally on master (pre-existingredoc-cliReact "Invalid hook call" dependency conflict, unrelated to this change)Acceptance criteria
orientationappears understrategyfor all 4 ops (shared schema)cost,availability) documented via enumcoststatedexample: cost