fix(mysql): allow sql.arg to be replace when preceeded with NOT or !#4499
Open
theoriginalstove wants to merge 1 commit into
Open
fix(mysql): allow sql.arg to be replace when preceeded with NOT or !#4499theoriginalstove wants to merge 1 commit into
theoriginalstove wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MySQL engine converted every unary operator to an opaque TODO node, so a negated argument like
WHERE NOT sqlc.arg('foo')was never traversed by the rewrite pass andsqlc.arg()leaked into the generated SQL. This converts logical negation to a BoolExpr, which then walk and rewrite passes already handle.Fixes #3933