feat: improve filename handling in extractAll (custom names & Chinese fix) - #544
Open
nonameShijian wants to merge 5 commits into
Open
feat: improve filename handling in extractAll (custom names & Chinese fix)#544nonameShijian wants to merge 5 commits into
nonameShijian wants to merge 5 commits into
Conversation
Check UTF-8 name in 0x7075 extra field to avoid false "File header and local file header mismatch" error for non-ASCII filenames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances
ZipFile.extractAll()to better handle real-world ZIP files with non-ASCII (e.g. Chinese) filenames and supports custom output naming.Changes
Fix "File header and local file header mismatch" for Unicode filenames
0x7075(Info-ZIP Unicode Path) extra field to get the correct UTF-8 filenameSupport custom output filenames via
newFileNameMapBenefits
This makes
extractAll()more robust and user-friendly for international use cases.