Skip to content

refactor: Extract apply and update status steps - #856

Merged
adwk67 merged 18 commits into
mainfrom
feat/smooth-operator/extract-apply-step
Aug 10, 2026
Merged

refactor: Extract apply and update status steps#856
adwk67 merged 18 commits into
mainfrom
feat/smooth-operator/extract-apply-step

Conversation

@adwk67

@adwk67 adwk67 commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

This PR covers the following:

  • extracts apply and update_status steps
  • moves secret creation to the apply step
  • moves object_meta out of the validated cluster code (missed on the last iteration of PRs)
  • ensure correct label versions are used in the tests (ditto)

Note

the Applier here deliberately diverges from the airflow shape (apply → apply_config_maps → finish, with orphan deletion only at the end) because the discovery ConfigMaps can only be built from the applied router Listener -this will apply to zookeeper as well..

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67

adwk67 commented Jul 30, 2026

Copy link
Copy Markdown
Member Author
--- PASS: kuttl (542.07s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_druid-37.0.0_zookeeper-3.9.5_hadoop-3.5.0_openshift-false (542.06s)
PASS

@adwk67
adwk67 marked this pull request as ready for review July 30, 2026 13:18
@adwk67
adwk67 requested a review from siegfriedweber July 30, 2026 13:49
Comment thread rust/operator-binary/src/controller.rs Outdated
Comment thread rust/operator-binary/src/controller/apply.rs Outdated
@adwk67
adwk67 requested a review from siegfriedweber August 5, 2026 14:54
Comment thread rust/operator-binary/src/controller/build/mod.rs Outdated
Comment thread rust/operator-binary/src/controller/dereference.rs Outdated
Comment thread rust/operator-binary/src/controller/apply.rs Outdated
Comment thread rust/operator-binary/src/controller/apply.rs
Comment thread rust/operator-binary/src/controller/migrate.rs Outdated
@adwk67
adwk67 requested a review from siegfriedweber August 7, 2026 14:32
siegfriedweber
siegfriedweber previously approved these changes Aug 10, 2026

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67

adwk67 commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

🟢 Openshift smoke test passes

--- PASS: kuttl (242.50s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_druid-37.0.0_zookeeper-3.9.5_hadoop-3.5.0_openshift-true (242.04s)
PASS

@adwk67
adwk67 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit bf87de4 Aug 10, 2026
18 checks passed
@adwk67
adwk67 deleted the feat/smooth-operator/extract-apply-step branch August 10, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants