Skip to content

Refactor variants.get_snv into two or more functions #11

Description

@grosscol

Issue or current state

In practice, lookup of snv is by accession identifier (rsid) xor by position (chrom-pos)

variants.get_snv(args['variant_id'], None, None, args['full']):
variants.get_snv(None, args['chrom'], args['pos'], args['full']):
variants.get_snv(query, None, None, False):

Resolved when

  • Uses of get_snv are refactored into get_accession_snv and get_position_snv.
  • Tests illustrate expected use.
  • Return type and data format is documented.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageLanding area for issues discovered during development.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions