refactor: add require! macro for consistent revert messages - #130
Open
MarcusDavidG wants to merge 1 commit into
Open
refactor: add require! macro for consistent revert messages#130MarcusDavidG wants to merge 1 commit into
MarcusDavidG wants to merge 1 commit into
Conversation
Introduces a require!(cond, msg) macro that wraps assert! with a literal message. Replaces the raw assert! in require_not_paused and establishes the pattern used throughout subsequent feature PRs. Panic messages are visible in transaction error metadata and test output, improving debuggability. Closes #123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a
require!(cond, msg)macro (mirrors Solidity'srequire) that wrapsassert!with a string literal message.Why
assert!messages are already strings, butrequire!signals intent clearly#[should_panic(expected = ...)]annotationsChanges
require!macro defined inlib.rsbefore first userequire_not_pausedupdated to userequire!Closes #123