refactor: extract _refund_payers helper to deduplicate refund logic - #131
Open
MarcusDavidG wants to merge 1 commit into
Open
refactor: extract _refund_payers helper to deduplicate refund logic#131MarcusDavidG wants to merge 1 commit into
MarcusDavidG wants to merge 1 commit into
Conversation
refund(), cancel_invoice(), and resolve_dispute(release=false) all iterated payments, aggregated by payer, and transferred. This extracts that logic into a single private _refund_payers() helper. - ~40 lines of duplicated code removed - Behaviour is identical — Map aggregation + pyr event per payer - resolve_dispute updated to use the helper Closes #122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three functions (
refund,cancel_invoice,resolve_dispute) each contained identical ~15 line blocks: iterate payments → aggregate by payer into a Map → transfer → emitpyrevent.Changes
_refund_payers(env, invoice_id, invoice)helperrefund(),cancel_invoice(), andresolve_dispute(release=false)all delegate to itCloses #122