feat: add pay_with_tip — extend pay() with optional gratuity - #133
Open
MarcusDavidG wants to merge 1 commit into
Open
feat: add pay_with_tip — extend pay() with optional gratuity#133MarcusDavidG wants to merge 1 commit into
MarcusDavidG wants to merge 1 commit into
Conversation
Adds pay_with_tip(payer, invoice_id, amount, tip) which behaves identically to pay() but accepts an optional tip transferred directly to the treasury address. - tip is stored on the Payment record for audit purposes - tip does NOT count toward invoice.funded or get_payer_total - tip=0 is valid and identical to calling pay() - treasury is read from instance storage (set at initialize time) - Payer index updated same as pay() Closes #110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
pay_with_tip(payer, invoice_id, amount, tip)— identical topay()but with an optional gratuity sent directly to the treasury.Behaviour
amountgoes to the contract vault and counts towardinvoice.fundedtipgoes directly to the treasury in a separate transfer — never held by the contracttipis stored on thePaymentrecord for audit purposes but does not count towardget_payer_totaltip=0is valid and behaves identically topay()pay()pay()when fully fundedCloses #110