Sundayjob996 e fix cancel race - #357
Merged
james2177 merged 3 commits intoSep 2, 2026
Merged
Conversation
…o fix cancel/expiry/slash race conditions IntentsController.cancel() used a check-then-update() sequence that could race with a concurrent accept() or sweeper expiry. IntentsSweeperService.sweep() had the same class of race for expiry (vs cancel/accept) and slashing (vs fill), both using the generic update() with no state guard. Adds cancelIfOpen/expireIfOpen/slashIfAccepted to IIntentsRepository, mirroring the existing acceptIfOpen/fillIfAccepted atomic-update pattern, implemented in both the in-memory and Prisma repositories, and wires the controller and sweeper to use them instead of read-check-update().
registeredAt was the only timestamp on a solver record, making it impossible to distinguish a solver that registered once and has been dormant since from one that's continuously active. Adds lastActiveAt (Unix epoch seconds) to SolverRecord and the Solver Prisma model, updated on registration, successful fill, and any deactivate/reactivate/deregister/markLive/markOffline call. Wires IntentsController.fill() to bump it via a new SolversService.recordSuccessfulFill(). Data model and write-path only, per issue scope.
|
@sundayjob996 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #280
closes #282
closes #283
closes #285