fix: implement test suite improvements for issues 205-208 - #331
Merged
james2177 merged 5 commits intoSep 3, 2026
Conversation
…ntion Implement anti-spam cooldown mechanism for user cancellations with a 1-hour delay between cancellations per user to prevent spam and improve system stability. Closes stellar-vortex-protocol#205
Add missing closing brace for pauser_cannot_unpause test function and import CANCEL_COOLDOWN constant for use in cancellation tests. Closes stellar-vortex-protocol#206
…losing braces Add missing closing braces to slash_cooldown_expires_after_time_window and get_protocol_params_returns_current_constants test functions to fix syntax errors. Closes stellar-vortex-protocol#207
Implement three incomplete test functions: - single_fill_at_or_above_minimum_completes_immediately: test single fill at or above minimum amount completes intent immediately - double_slash_second_call_rejected: test that double slash on same intent fails with IntentNotAccepted error - fill_intent_fee_overflow_returns_error: test fee overflow boundary detection when fill amount exceeds i128::MAX / 5 Closes stellar-vortex-protocol#208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements test suite improvements to fix multiple issues:
fill_intent#205: Add CANCEL_COOLDOWN constant for intent cancellation spam preventionproof_registrymock back-door so it provably cannot exist in a production build #206: Fix pauser_cannot_unpause test function missing closing braceChanges
Issue #205
Added
CANCEL_COOLDOWNconstant (1 hour) to enforce anti-spam mechanism for user intent cancellations, preventing rapid-fire cancellations by a single user.Issue #206
Fixed syntax error in
pauser_cannot_unpausetest function by adding missing closing brace and importing CANCEL_COOLDOWN constant for use in cooldown-related tests.Issue #207
Fixed syntax errors in two test functions:
slash_cooldown_expires_after_time_window: Added missing closing braceget_protocol_params_returns_current_constants: Added missing closing braceIssue #208
Implemented three incomplete test functions:
single_fill_at_or_above_minimum_completes_immediately: Tests that a single fill at or above the minimum amount completes an intent immediatelydouble_slash_second_call_rejected: Tests that attempting to slash the same intent twice fails with IntentNotAccepted errorfill_intent_fee_overflow_returns_error: Tests fee overflow boundary detection when fill amount exceeds i128::MAX / 5Test Plan
All test implementations follow established test patterns in the codebase:
Closes #205
Closes #206
Closes #207
Closes #208