add check for wall solvers when particle centers fall outside the wall - #85
Merged
Conversation
|
✅ Linter reported no issues All Python files are correctly formatted with Black. |
|
✅ Linter reported no issues All C/C++ files are correctly formatted with clang-format. |
Contributor
|
No idea about this error: |
…x type causing a later function to fail. eigh explicitly ignores the imaginary parts of eigenvalues
Contributor
Author
|
@RaulPPelaez looks good now, just some weird type error from a change in numpy and/or scipy |
RaulPPelaez
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the most common issue I see when people message me is Lanczos being unclear when a particle goes through a wall since sqrtMdotW reports Lanczos as having NANs in the result.
This adds a check when positions are set in NBody and DPStokes to make sure the center of the particle is on the correct side of the wall. I also moved some logic in NBody from MDot to set positions to save a tiny bit of calculation (and since it seemed more logical).