feat: install yq in agent base-tools image - #15
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rokej The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
Next review available in: 21 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesThe build workflow now pins and propagates YQ Integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@containerfiles/Containerfile.agents`:
- Around line 68-80: Add integrity verification to the yq download step in the
Containerfile’s yq installation block: select a trusted, version-specific
checksum or official signature for each ARCH_SHORT value, verify the downloaded
artifact before chmod or execution, and fail the build on mismatch. Keep the
verification metadata synchronized with YQ_VERSION through the existing
dependency-update flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: cb18d19e-1be5-4e70-be48-5f74bb06f0a5
📒 Files selected for processing (6)
AGENTS.mdMakefileREADME.mdcontainerfiles/Containerfile.agentsdocs/ARCHITECTURE.mdscripts/build.sh
Cluster nodes are amd64; Mac arm hosts otherwise build the wrong architecture or fail UBI TLS under qemu inconsistently. Co-authored-by: Cursor <cursoragent@cursor.com>
|
PR Hygiene: Converted to draft This PR has had no new commits for 4 business days and has been converted to draft. It will be closed automatically in 5 business days if no new commits are pushed. To prevent automatic closure, push a commit or add the -- PR Hygiene Agent |
Summary
yq(v4.53.3) inbase-toolsso OpenCode/Crush sandboxes can run SFA scripts that parserepos/repos.yaml(fetch-prs.sh,sync-repos.sh)YQ_VERSIONin the Makefile, pass it throughbuild.sh, and include it inupdate-depsWhy
agent-pr-action-neededhard-failed in swarm:yqnot installed and not installable in the sandbox. No script workaround — ship the binary in the image.Test plan
make build-opencode NOPROMPT=1succeedspodman run --rm <image> yq --versionprints v4.53.3bash .claude/skills/sfa-github-fetch-prs/fetch-prs.sh basiclists SF repos without a yq errorAGENT_IMAGE_OPENCODEon the swarmer deployment to the new tagMade with Cursor
Summary by CodeRabbit
New Features
yqcommand-line utility to agent images, with architecture-specific installation and version verification.yqversion.Documentation
yqutility.Chores
yqversion.