added mock interview problem. - #28
Open
krishnadheerajkrovi wants to merge 1 commit into
Open
Conversation
Owner
|
The solution demonstrates a solid understanding of the problem using a Common Table Expression (CTE) approach. The logic is sound: finding the minimum year per product and then joining back to get all sales from that first year. The comments are helpful for understanding the approach. However, there are some areas for improvement: the query doesn't include a primary ordering requirement (if the problem expects ordered results), and while the solution handles the core logic correctly, it could benefit from more explicit column selection and potential edge case handling (like products with no sales). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review