Skip to content

added mock interview problem. - #28

Open
krishnadheerajkrovi wants to merge 1 commit into
super30admin:mainfrom
krishnadheerajkrovi:main
Open

added mock interview problem. #28
krishnadheerajkrovi wants to merge 1 commit into
super30admin:mainfrom
krishnadheerajkrovi:main

Conversation

@krishnadheerajkrovi

Copy link
Copy Markdown

Please review

@super30admin

Copy link
Copy Markdown
Owner

The solution demonstrates a solid understanding of the problem using a Common Table Expression (CTE) approach. The logic is sound: finding the minimum year per product and then joining back to get all sales from that first year. The comments are helpful for understanding the approach. However, there are some areas for improvement: the query doesn't include a primary ordering requirement (if the problem expects ordered results), and while the solution handles the core logic correctly, it could benefit from more explicit column selection and potential edge case handling (like products with no sales).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants