drone: don't run the pipeline on pull_request (stop red PR builds)#7
Closed
cyberb wants to merge 1 commit into
Closed
drone: don't run the pipeline on pull_request (stop red PR builds)#7cyberb wants to merge 1 commit into
cyberb wants to merge 1 commit into
Conversation
pull_request builds are red anyway: the artifact step uses the artifact_key secret, which drone withholds from pull_request events, so every PR build fails at that step even though build/test pass. Drop the pull_request trigger so the pipeline runs only on push and tag.
Member
Author
|
Folded into #6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every
pull_requestbuild is red even though build/test pass. Theartifactstep uses theartifact_keysecret, which drone withholds frompull_requestevents, so it always fails at that step — a spurious red check on every PR.Fix
Drop
pull_requestfrom the pipeline trigger, so it runs only onpushandtag. PRs still get a green branchpushbuild; the noisy failingpull_requestbuild is gone.Matches the convention already used across the recently-updated syncloud projects (navidrome, files, platform, …). Validated with
drone jsonnet+drone lint.