Update pluggable-db-adapter plan: PRAGMA status + better-sqlite3 E2E test - #43
Merged
Conversation
…test Two updates: 1. PRAGMAs section updated to reflect PR #42 as merged/verified (grep -ri PRAGMA src/ returns zero matches). Previously the doc framed PRAGMA removal as a future prerequisite; now it is done. 2. Testing strategy gains an end-to-end test on BetterSqlite3Adapter. better-sqlite3 is a pure Node install (no simulator, no WASM toolchain) so it can run in the same vitest invocation as the sql.js tests, giving CI coverage on at least one non-sql.js adapter without requiring RN-specific CI. Op-sqlite and expo-sqlite remain manual/local. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only update to
documents/pluggable-db-adapter.md.grep -ri PRAGMA src/returns zero matches). Previously the doc described PRAGMA removal as a future prerequisite.BetterSqlite3Adapter. better-sqlite3 is pure Node (no simulator, no WASM toolchain) so it can run in CI alongside sql.js. Op-sqlite and expo-sqlite remain manual/local.better-sqlite3+ the E2E test as part of the initial refactor.BetterSqlite3Adapteris promoted from copy-paste example to a CI-run reference, with theexamples/copy staying canonical for consumers.Test plan
🤖 Generated with Claude Code