Add projects s3 upload and fix s3 list envelope - #3
Open
goclfc wants to merge 2 commits into
Open
Conversation
CLI: usectl projects s3 upload <id> --key --file talks to manager PUT /api/projects/{id}/s3/objects?key=
List unmarshals {objects, prefixes, prefix, bucket} instead of a bare array.
Shared client is 30s; same special-case as image-part push (Timeout 0). Set Content-Length from the file size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usectl projects s3 upload <project-id> --key --filePUTs raw bytes to/api/projects/{id}/s3/objects?key=(manager API, same auth as list/download).{objects, prefixes, prefix, bucket}instead of a bare[]S3Object.Ken owns the PUT handler and making list a real bucket read. One list shape only.
Test plan
usectl projects s3 upload <id> --key proof.txt --file ./proof.txt --jsonusectl projects s3 list <id> --jsonreturns{objects, prefixes, ...}